[debexpo-devel] parsing gpg key ids

Jonny Lamb jonnylamb at jonnylamb.com
Sun Feb 1 18:08:17 CET 2009


On Mon, Jan 19, 00:19:18 +0000, Serafeim Zanikolas wrote:
> I'm sending over a patch that parses the key id of GPG keys and stores them in
> a newly added column, so that it's parsed only when it's uploaded (any
> existing DBs will have to be recreated). It assumes that gpg2 is in $PATH.

Cool, thanks very much for the patch. A few comments:

 * Please hard-code the path to the GPG executable in the configuration
   file. The default should of course be "/usr/bin/gpg2".

 * I'm merely a user of GPG, but I'd recommend using gnupg instead of
   gnupg2 as the former is "Priority: important" and the latter is
   "Priority: optional". As a result, it will be installed on more
   machines. Please do point out the advantage of using gnupg2 to me
   though.

 * The reason I didn't implement the key checking like this in the first
   place is that it feels like a duplication of data. But the cost of
   storing a little string in the database clearly is better than
   calling out to an executable every time, unless there's another way
   to get it?

 * I tried to make debexpo rather pythonic. It would be nicer if debexpo
   used some kind of Python GPG binding, as opposed to calling out to
   /usr/bin/gnupg directly and mangling the string. For example, I see
   the python-gnupginterface package.

> The patch also has a couple of other minor changes:
> 
> - allow non @debian.org emails in debug mode
> - add a bit of padding in the HTML table that lists uploaded packages
>   (previously some cells looked crammed together)

These are both great ideas. Could you split the patch for each change
though please?

Thanks again for the patch, and I'm sorry I've taken so long to get back
to you about it.

-- 
Jonny Lamb, UK
jonnylamb at jonnylamb.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://workaround.org/pipermail/debexpo-devel/attachments/20090201/046210bf/attachment.pgp>


More information about the debexpo-devel mailing list