[debexpo-devel] patch: deal gracefully with incomplete uploads
Jonny Lamb
jonny at debian.org
Wed Feb 18 20:43:26 CET 2009
Sorry for the lack of response from me recently: the workload at uni is
high right now, but will be much better after Friday.
On Mon, Feb 16, 23:59:27 +0000, Serafeim Zanikolas wrote:
> - os.remove(file)
> + os.path.exists(file) and os.remove(file)
I don't like this. This is the kind of thing I write in shell scripts
and feel bad about doing so. I'd prefer if debexpo was more pythonic.
> + # Check for missing files
> + missing_files = [f for f in toinstall if not os.path.exists(f)]
> + if missing_files:
> + self._reject('The following files are listed in the .changes ' +
> + 'file but have not been uploaded:\n\n%s' %
> + "\n".join(missing_files))
> +
Isn't this already in the checkfiles plugin?
--
Jonny Lamb, UK
jonny at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://workaround.org/pipermail/debexpo-devel/attachments/20090218/b49fd5fa/attachment.pgp>
More information about the debexpo-devel
mailing list