[debexpo-devel] [PATCH] Use 404s instead of redirects for empty or invalid registration tokens (Closes ticket #78)

Paul Wise pabs at debian.org
Sat Jul 25 18:26:45 CEST 2009


---
 debexpo/controllers/register.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debexpo/controllers/register.py b/debexpo/controllers/register.py
index 2219866..4dcd61a 100644
--- a/debexpo/controllers/register.py
+++ b/debexpo/controllers/register.py
@@ -172,8 +172,8 @@ class RegisterController(BaseController):
         log.debug('Activation request with key = %s' % id)
 
         if id is None:
-            log.error('Key is None; redirecting to main page')
-            h.redirect_to(h.url_for(action=None))
+            log.error('Key is None')
+            abort(404, 'Key is None')
 
         user = meta.session.query(User).filter_by(verification=id).first()
 
@@ -183,7 +183,7 @@ class RegisterController(BaseController):
             meta.session.commit()
         else:
             log.error('Could not find user; redirecting to main page')
-            h.redirect_to(h.url_for(action=None, id=None))
+            abort(404, 'Could not find user; redirecting to main page')
 
         c.user = user
         return render('/register/activated.mako')
-- 
1.6.3.3
-- 
bye,
pabs

http://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://workaround.org/pipermail/debexpo-devel/attachments/20090725/7771cc40/attachment.pgp>


More information about the debexpo-devel mailing list